dongjoon-hyun commented on PR #885: URL: https://github.com/apache/spark-kubernetes-operator/pull/885#issuecomment-5826169038
Thank you so much for the thorough review, @MaxGekk! All three comments are addressed in 9788f16. - **Per-resource deletion**: `releaseResources` catches each failed deletion, keeping the first one and suppressing the others, so the driver pod is always asked to go even if a pre-resource cannot be deleted. - **Retried `Workload` release**: The release uses `deleteWorkloadOf`, and a failure keeps the application in its state until the next pass succeeds. So neither the next attempt nor a terminated application keeps the previous admission. Like a suspended `SparkCluster`, a persistent failure, e.g. a revoked access, holds the application until the access is restored, and the documentation mentions it. - **Force-deleted pods**: The javadoc of `getWaitForPodsDeadline` notes that the wait cannot observe a force-deleted pod while the kubelet stops its containers. New test cases: `everyResourceIsDeletedEvenIfAnotherFails` and `failedWorkloadReleaseIsRetriedBeforeRestart`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
