sarutak commented on code in PR #59114:
URL: https://github.com/apache/spark/pull/59114#discussion_r4130673197
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorResizePluginSuite.scala:
##########
@@ -365,4 +365,20 @@ class ExecutorResizePluginSuite
assert(result.isEmpty)
}
}
+
+ test("SPARK-59842: resizeInterval defaults to 1 minute") {
+ assert(new SparkConf(false).get(EXECUTOR_RESIZE_INTERVAL) === 60)
+ }
+
+ test("SPARK-59842: init returns early when resizeInterval is 0") {
Review Comment:
The two added tests cover (a) default = 60s and (b) `0` -> early return. The
core of bug (B) was that `0` caused `scheduleAtFixedRate(period = 0)` to throw
`IllegalArgumentException`. Consider adding an `interval > 0` case that asserts
`init` completes normally (schedules without throwing). Without it, future
widening of the early-return condition could still pass (a)/(b). Optional,
since the mock-based style makes this somewhat verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
