LuciferYang commented on PR #59121: URL: https://github.com/apache/spark/pull/59121#issuecomment-5886754664
Checked whether this cleanly reverts #55925 and #57826, and it does. Re-running `git revert` of both commits on the base produces a tree identical to this PR's head except for two trailing blank lines in `ExpandBenchmark-jdk21-results.txt` that a plain revert keeps. Both reverts apply without conflict; only `SQLConf.scala` needed an auto-merge. No reference to the removed config remains anywhere in the tree, and the feature is fully contained in these two commits, so nothing else depends on it. One non-blocking note: the restored `ExpandBenchmark.scala` still runs the `Expand: subexpression elimination across branches` section, but none of the three result files carry it (jdk21 loses it here, jdk25/default never had it on master). That lag predates #57826, so the revert just restores it, and it also drops the section that only jdk21 carried, so the three files line up again. Benchmarks aren't in CI, so this doesn't block anything; regenerate the result files after merge if you want it fully clean. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
