peter-toth commented on PR #58895: URL: https://github.com/apache/spark/pull/58895#issuecomment-5895124425
@dongjoon-hyun thank you. Round 5 is answered in the threads, and the description is up to date. - A checked `SparkException` from a Hive UDF key fails open now, both per row and for the constant of a file missing its key column. Both cases have a test. - The retry is simpler, as you proposed. The unreachable widening, the terminator overrides and `hitEndOfData` are gone, and the base class keeps master's `nextBatch` check. - The dictionary-id memoization is a follow-up in the description. - Everything else is fixed as you suggested. Since this round reviewed the restructured reader, I am keeping that shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
