peter-toth commented on code in PR #909:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/909#discussion_r4136778250
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/ClusterInitStep.java:
##########
@@ -78,8 +78,7 @@ public ReconcileProgress reconcile(
// Whether the master is live is unknown, not answered. Holding would
claim in an event
// that none was requested, and would release the Kueue quota of a
running master, so
// look again with the steady-state interval instead.
- log.warn("Failed to check whether the master of a suspended cluster
exists.", e);
- return completeAndDefaultRequeue();
+ return SuspendUtils.retryAfterCheckFailure(context, e, "master and
workers");
Review Comment:
**Finding 1.** With `"master and workers"` the message reads "Failed to
check whether the master and workers of the suspended SparkCluster was
requested". `isMasterRequested` reads only the master StatefulSet, and the new
`SuspendCheckFailed` row in `configuration.md` says "the master of a suspended
`SparkCluster`". Passing `"master"` fixes the grammar and matches both. The
assertion at `ClusterInitStepTest.java:899` would then check for `"master of
the suspended SparkCluster"`.
```suggestion
return SuspendUtils.retryAfterCheckFailure(context, e, "master");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
