Spenserrrr commented on code in PR #59019: URL: https://github.com/apache/spark/pull/59019#discussion_r4137318045
########## python/pyspark/tests/test_worker.py: ########## @@ -31,9 +34,37 @@ from py4j.protocol import Py4JJavaError from pyspark import SparkConf, SparkContext +from pyspark.serializers import read_int from pyspark.testing.utils import PySparkTestCase, QuietTest, ReusedPySparkTestCase, eventually +class WorkerProtocolTests(unittest.TestCase): Review Comment: Removed the direct Python protocol test. Existing UDF integration tests exercise worker communication and read SQL metrics on the JVM; the retained spill test reads task metrics from the driver. I also ran `bench_eval_type.ArrowBatchedUDFTimeBench` locally with ASV `--quick`: all 24 parameter combinations passed. The benchmark supplies input through `BytesIO` and does not parse the output metrics, so it requires no changes for the JSON report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
