uros-b commented on PR #59078: URL: https://github.com/apache/spark/pull/59078#issuecomment-5897291452
Otherwise, this seems like a correct, minimal, and well-tested bug fix: the nullability narrowing is provably safe because the rewrite always produces a grouping aggregate over a non-empty group, and the fix stays scoped to the rewrite rather than touching First globally (the rejected #42117 approach). Tests assert real behavior (optimized-plan schema equality, a successful NOT NULL DSv2 append, empty-input returns no rows, and that ordinary global first still returns null), not just plan shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
