cloud-fan commented on PR #59094:
URL: https://github.com/apache/spark/pull/59094#issuecomment-5900978189
The production fixes look correct. One test gap remains: the row-evaluated
invalid-k case mixes a valid sketch with the NULL row, so the valid row can
raise the expected error even if NULL rows bypass validation. Please make that
assertion depend only on a non-foldable NULL state.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5899868919","thread_id":"conversation:5899868919","verdict_sha256":"6b63c2917281883e3f60bf65eaebe1be2b87a41d6d3ee2fd016a578b153547cc"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
