metanil commented on code in PR #55885:
URL: https://github.com/apache/spark/pull/55885#discussion_r4139439754
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/functions/ReducibleFunction.java:
##########
@@ -101,6 +155,6 @@ default Reducer<I, O> reducer(
* @return a reduction function if it is reducible, null if not.
*/
default Reducer<I, O> reducer(ReducibleFunction<?, ?> otherFunction) {
- throw new UnsupportedOperationException();
+ return reducer(new Literal<?>[0], otherFunction, new Literal<?>[0]);
Review Comment:
Ya, I wanted to avoid adding implementation detail in javadoc, but good idea
to add was part of `@implNote`. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
