szehon-ho commented on code in PR #58632: URL: https://github.com/apache/spark/pull/58632#discussion_r4139924718
########## sql/catalyst/src/main/java/org/apache/spark/sql/internal/connector/ConfigurableSchemaAlignment.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.internal.connector; + +import org.apache.spark.sql.connector.catalog.Table; + +/** + * Allows connectors to configure schema alignment and casting behavior for DSv2 batch/row-level + * writes to a {@link Table}. It is not consulted for streaming writes, where alignment is + * delegated to the connector. + */ +public interface ConfigurableSchemaAlignment extends Table { Review Comment: Hm.. i think @gengliangwang comment is about the top level interface `ConfigurableSchemaAlignment` and not necessarily `SchemaAlignmentConfig`. Should it be `Supports...` or something more in line with V2? This somehow feels a bit off (doesn't start with a verb), but its subjective -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
