haiyangsun-db commented on code in PR #58859: URL: https://github.com/apache/spark/pull/58859#discussion_r4141899455
########## core/src/main/scala/org/apache/spark/internal/config/UDF.scala: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.internal.config + +private[spark] object UDF { + + val DISPATCHER_FACTORY = ConfigBuilder("spark.udf.worker.dispatcherFactory") Review Comment: After thinking this again, this probably should not be the final state. The ideal case is that custom logic should be wired via the worker spec contract. In most of cases, Spark should be able to offer the generic dispatching logic by default without needing a custom dispatcher (generalizing what pyspark is doing nowadays). And it's also possible to offer several dispatching options in spark. So this config ideally could be replaced with an enum to choose between few built-in dispatching options rather an arbitrary class. Directly allow arbitrary custom logic here can make the behavior unpredictable for the engine. I created a new ticket to follow up on this: https://issues.apache.org/jira/browse/SPARK-59886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
