LukaZdravic commented on code in PR #59102:
URL: https://github.com/apache/spark/pull/59102#discussion_r4142640188
##########
sql/core/src/test/scala/org/apache/spark/sql/AsOfJoinSortMergeSQLSuite.scala:
##########
@@ -204,6 +204,26 @@ class AsOfJoinSortMergeSQLSuite extends QueryTest
Row(180.15) :: Nil)
}
+ test("TIMESTAMP MATCH_CONDITION with legacy intervals") {
+ // TIMESTAMP - TIMESTAMP is then a CalendarInterval, which has no
ordering. Backward and
Review Comment:
Done, thanks
##########
sql/core/src/test/scala/org/apache/spark/sql/AsOfJoinSortMergeSQLSuite.scala:
##########
@@ -204,6 +204,26 @@ class AsOfJoinSortMergeSQLSuite extends QueryTest
Row(180.15) :: Nil)
}
+ test("TIMESTAMP MATCH_CONDITION with legacy intervals") {
+ // TIMESTAMP - TIMESTAMP is then a CalendarInterval, which has no
ordering. Backward and
+ // Forward never read that distance, so they must still run.
+ withSQLConf(SQLConf.LEGACY_INTERVAL_ENABLED.key -> "true") {
+ for ((op, tag) <- Seq(">=" -> "r9", ">" -> "r9", "<=" -> "r11", "<" ->
"r11")) {
Review Comment:
Added, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
