haiyangsun-db commented on code in PR #59111:
URL: https://github.com/apache/spark/pull/59111#discussion_r4146295602
##########
udf/worker/proto/src/main/protobuf/org/apache/spark/udf/worker/udf_message.proto:
##########
@@ -407,9 +407,8 @@ message Finish {}
// introduced as a separate streaming message in a future revision
// without changing this contract. TODO(SPARK-56922).
message FinishResponse {
- // Per-execution metrics accumulated over the session. Free-form;
- // names are worker-defined.
- map<string, string> metrics = 1;
+ // (Optional) Final metrics accumulated over this Execute stream.
+ optional ExecutionMetrics metrics = 1;
Review Comment:
can we append this field at the end of the message, it doesn't have to
replace the generic metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
