viirya opened a new pull request, #59166: URL: https://github.com/apache/spark/pull/59166
### What changes were proposed in this pull request? Backport #59074 (SPARK-59804, master commit 719947a5652f83a80492db50a6f1e5fe14d9e6b8) to `branch-3.5`. Adapt the replay diagnostics to the string-based logging API in Spark 3.5, preserving the messages and exception behavior. Add explicit filter parameter types where Scala 2.12 cannot infer them for overloaded replay calls. Retain the branch's `3.5.10` configuration version. The backport includes UTF-8 byte accounting, physical-line diagnostics, the 256 MiB default and 512 MiB maximum, the restored no-argument constructor, early release of skipped-line buffers, bounded malformed-line excerpts, documentation, and regression tests. Independent follow-ups from the original PR remain outside this backport. ### Why are the changes needed? `branch-3.5` contains SPARK-59407 (8defa3c9418), so it has the same byte-limit, diagnostic, and constructor regressions fixed by #59074. The master patch needs logging API adaptation on this branch. ### Does this PR introduce _any_ user-facing change? Yes, the same fixes as #59074: limits measure UTF-8 content bytes excluding line endings; the default is 256 MiB; non-positive and above-maximum settings resolve to 512 MiB. Replay preserves physical line numbers across skipped lines, bounds malformed-line excerpts, and restores the JVM no-argument constructor. ### How was this patch tested? On branch-3.5 with Java 17.0.16 and Scala 2.12.18, using the company Maven proxy: ``` build/sbt 'core/testOnly *ReplayListenerSuite' build/sbt 'core/Compile/scalastyle' 'core/Test/scalastyle' ``` All 19 tests and both scalastyle checks passed. The tests cover UTF-8 boundaries, normalized constructor replay, reflective no-argument construction, buffer release, physical-line diagnostics, bounded error excerpts, and IO exception handling. Existing compressed/end-to-end tests retain the assertion limitations documented in #59074; their independent follow-up remains outside this backport. Also checked the compiled class with `javap`: both constructors and the Scala default-argument method are present. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
