dongjoon-hyun commented on code in PR #916: URL: https://github.com/apache/spark-kubernetes-operator/pull/916#discussion_r4158702527
########## docs/configuration.md: ########## @@ -223,6 +229,10 @@ via [Codahale JVM Metrics](https://javadoc.io/doc/com.codahale.metrics/metrics-j | kubernetes.client.`ResourceName`.`Method` | Meter | Tracking the rates of HTTP request for a combination of one Kubernetes resource and one http method | | kubernetes.client.`NamespaceName`.`ResourceName`.`Method` | Meter | Tracking the rates of HTTP request for a combination of one namespace-scoped Kubernetes resource and one http method | +A request which gets no response is counted in `kubernetes.client.http.response.failed` only when +the client retries it. So a request which the client does not retry, i.e. a Kubernetes event write +or the update of the Kueue `PodsReady` condition, is not counted there when it gets no response. Review Comment: Thank you for the review, @peter-toth. You're right on both points. The meter is `kubernetes.client.failed`, and fabric8 calls `afterConnectionFailure` while a request still has a retry left, even when it does not retry it, e.g. on a request timeout. I applied your suggestion and fixed the same reason in the `withoutRetries` Javadoc and the test comment. Thank you for filing SPARK-59927 for the older table rows, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
