charliec05 commented on code in PR #58536:
URL: https://github.com/apache/spark/pull/58536#discussion_r4159262535
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala:
##########
@@ -216,26 +217,22 @@ private[sql] object JDBCRelation extends Logging {
private def toBoundValueInWhereClause(
value: Long,
columnType: DataType,
- timeZoneId: String): String = {
- def dateTimeToString(): String = {
- val dateTimeStr = columnType match {
+ timeZoneId: String,
+ dialect: JdbcDialect): String = {
+ def compileDateTimeValue(): String = {
+ val dateTimeValue = columnType match {
Review Comment:
Hi @urosstan-db, could you take another look at the explicit-conversion
approach in my reply above when convenient? The remaining question is whether
retaining DateTimeUtils for the explicit bound time zone and proleptic
calendar, while sharing the dialect formatter, addresses your concern. The
updated full CI passed, including Docker integration. I've left this thread
open for your confirmation. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
