TQJADE commented on code in PR #909: URL: https://github.com/apache/spark-kubernetes-operator/pull/909#discussion_r4160587252
########## docs/spark_custom_resources.md: ########## @@ -544,7 +544,12 @@ published when enabled. Since the status is not there to fall back on, it is rep minutes by default while the hold lasts, so that it outlives the event retention of the API server. An application held later, in `ScheduledToRestart`, keeps the status its previous attempt already wrote and gets the same event, since that status says that a restart is due, not that the -next attempt is withheld. +next attempt is withheld. If the driver (or master) cannot be read to check whether it was requested +already, e.g. since the API server rejects the read, the resource is neither held nor started, and Review Comment: updated. ########## docs/configuration.md: ########## @@ -93,6 +93,7 @@ In addition, the operator publishes the following `Warning` events. | `KueueAdmissionRequestFailed` | Creating, reading or deleting a stale Kueue `Workload` fails, or the driver or master cannot be read before the admission is requested. Transport-level errors are skipped and retried every 5 seconds, while a persistent failure is retried with the default interval. | | `ClusterRequestFailed` | Applying the Services, StatefulSets, NetworkPolicy, HorizontalPodAutoscaler or PodDisruptionBudget of a `SparkCluster` fails in a way which may yet succeed, such as a throttled request or an internal server error from an admission webhook, so it is retried with the default interval instead of failing the cluster. Transport-level errors are skipped. | | `SuspendReleaseFailed` | Deleting the master and worker StatefulSets, the HorizontalPodAutoscaler or PodDisruptionBudget of the workers, or the Kueue `Workload` of a `SparkCluster` suspended while running fails, or its pods cannot be listed. A failure which may clear on its own, such as a timeout, is skipped. Every failure is retried with the default interval. | +| `SuspendCheckFailed` | The driver of a suspended `SparkApplication`, or the master of a suspended `SparkCluster`, cannot be read to check whether it was requested, so the resource is neither held, which would release its Kueue `Workload`, nor started. Transport-level errors are skipped. Every such failure is retried with the default interval. While the failure lasts, it is republished on every reconciliation, subject to [`minIntervalSeconds`](#event-frequency). Once the check succeeds again, the unchanged `SuspendHeld` event may be dropped by the same interval until its next repeat, so this event can stay the newest one for up to 30 minutes (`spark.kubernetes.operator.reconciler.suspendHoldRequeueIntervalSeconds`). One which is no longer refreshed has cleared. | Review Comment: updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
