anuragmantri commented on PR #58979: URL: https://github.com/apache/spark/pull/58979#issuecomment-5943717358
Thanks for re-checking, @peter-toth. - **Nested sort key**: You're right. My last reply on that thread was meant for the pruned-column thread, and SPARK-59899 only covers sort orders on pruned columns. I reproduced it on this head: an ordering reported on `s.x` through `CustomReportingCatalog` still fails with `Once strategy's idempotence is broken for batch Early Filter and Projection Push-Down`. I filed SPARK-59948 for it and fixed the thread. - **5**: Completed the cut-off `V2ExpressionUtilsSuite` bullet in the description. - **6**: Added the `DataSourceV2Suite` test for connector-defined classes and the mixed key cases (e.g. `[id + 1, identity(missing)]`) to the testing section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
