vboo123 commented on PR #59004: URL: https://github.com/apache/spark/pull/59004#issuecomment-5945548534
Thanks @dongjoon-hyun, @sarutak, @shrirangmhalgi, @uros-b. Addressed in 0265c8f: 1. Guarded `=`, `<`, `<=`, `>`, `>=` against null and pushed `<=> NULL` as `IS NULL`. Added runtime scalar subquery tests. 2. Updated the description with the `ignoreCorruptFiles` wrong-result case. 3. Excluded `ReplaceNullWithFalseInPredicate` so `NOT IN` reaches ORC, and added the `OR label = 'b'` case. 4. Added a string `IN` case and noted the PPD-disabling failure mode. 5. Added `isin(3, 5, 7, null)` to the SPARK-10623 PPD test. 6. Pinned the expected `SearchArgument` strings. 7. Added the empty `IN` assertion and noted the behavior change in the description. 8–12. Reworded the comment, fixed the stale `values.map` reference, removed `select`/`orderBy`, moved the null check into the guard, and moved the test next to the PPD tests. 13. Switched to `Generated-by:`. @sarutak: added the Parquet-vs-ORC note to the code comment and the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
