HwangDongJun commented on code in PR #58187:
URL: https://github.com/apache/spark/pull/58187#discussion_r4163575524
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopConfDriverFeatureStep.scala:
##########
@@ -112,7 +112,9 @@ private[spark] class HadoopConfDriverFeatureStep(conf:
KubernetesConf)
}
}
- override def getAdditionalKubernetesResources(): Seq[HasMetadata] = {
+ // SPARK-38079: this config map is mounted by the driver pod, so it must be
created as a
+ // pre-resource (before the pod itself) to avoid a "configmap ... not found"
mount race.
+ override def getAdditionalPreKubernetesResources(): Seq[HasMetadata] = {
Review Comment:
Done, exactly as suggested. Both `SPARK-37331` tests in
`KubernetesDriverBuilderSuite` now set
`KUBERNETES_DRIVER_POD_EXCLUDED_FEATURE_STEPS` to exclude
`HadoopConfDriverFeatureStep`, so their size assertions no longer depend on
whether `HADOOP_CONF_DIR` happens to be set in the test JVM's environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
