dongjoon-hyun commented on code in PR #922: URL: https://github.com/apache/spark-kubernetes-operator/pull/922#discussion_r4164070069
########## docs/migration_guide.md: ########## @@ -81,6 +81,13 @@ affect building the project, CI, tests or examples. documented. 1.0 capped it at about 15 seconds, so with the other defaults, the retries now span about 49 minutes instead of about 3 minutes. To restore the behavior before 1.1.0, set it to `15` ([SPARK-59892](https://issues.apache.org/jira/browse/SPARK-59892)). +- Since 1.1.0, the `_sum` of the Prometheus summaries of the operator histograms and timers, e.g. + `kubernetes_client_http_response_latency_seconds_sum`, is the sum of all recorded values. 1.0 + exported the mean of roughly the last 5 minutes multiplied by the count instead, which can + decrease between scrapes, so `rate()` of it and the average derived from it were wrong. Also, the + `0.5` and `0.999` quantiles of the `operator_sdk_*` histograms are the median and the 99.9th + percentile instead of the mean and the 99th percentile. A histogram or timer of a custom metrics + source has no `_sum` unless it is a `SummingHistogram` or a `SummingTimer` ([SPARK-XXXXX](https://issues.apache.org/jira/browse/SPARK-XXXXX)). Review Comment: Thank you for the review, @peter-toth. I applied your suggestion in [`27894eb`](https://github.com/apache/spark-kubernetes-operator/commit/27894eb46b0e79a20b57ef1f662978e2123ac9c1). Thank you for filing SPARK-59949 for the whole seconds of the `operator_sdk_*` histograms, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
