markj-db commented on PR #59190: URL: https://github.com/apache/spark/pull/59190#issuecomment-5957688328
Thanks — both P3 nits are fixed in 4897472 (stale `supportsLargePartition` comments repointed at `checkPartitionSizeLimit`; the length test now asserts the return type via reflection). The PR title and description were also updated to match the unconditional-guard design (every window frame over Int.MaxValue rows fails with `WINDOW_FUNCTION_PARTITION_SIZE_EXCEEDS_LIMIT`; no `supportsLargePartition`, `inputIndex` stays `Int`), with the sorter-widening correctness work tracked as SPARK-59941. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
