pavan51 commented on PR #57346:
URL: https://github.com/apache/spark/pull/57346#issuecomment-5962906651
Thanks for the follow-up, @peter-toth!
I've addressed both of your remaining findings and the test name feedback
in the latest pushes:
1. Finding 31 (Blocking) - PR description scope:
I have updated the PR description body above to explicitly list the two
changes outside the new frame (SpillableArrayIterator implementing Closeable,
and SegmentTreeWindowFunctionFrame closing its spill readers). The commit
message was also updated.
2. Finding 30 (Non-blocking) - Signed-zero test:
Great catch on the Decimal literal. I updated the test to use CAST('-0.0'
AS DOUBLE) instead of CAST(-0.0 AS DOUBLE). This correctly produces an IEEE 754
-0.0, so the min-side keep-the-first-equal rule is now properly exercised and
verified.
3. Cleanup test claim:
I took your suggestion and dropped the cursor cleanup claim from the test
name and comment to avoid confusion. It's now just a standard correctness test
for multi-partition RANGE with spill.
Everything should be fully resolved now! Let me know if you need anything
else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
