HyukjinKwon commented on PR #59221:
URL: https://github.com/apache/spark/pull/59221#issuecomment-5965770224
On the recovery path you flagged: it looks correct to me.
recoverStatefulShufflePartitions only triggers for a V2 offset log that is
missing the stateful shuffle-partitions value, and that absence check resolves
through the STATEFUL_SHUFFLE_PARTITIONS_INTERNAL -> SHUFFLE_PARTITIONS rebind
to the same offset-log key that withStatefulShufflePartitions writes, so the
guard and the writer agree. It reads the count from the committed batch's state
metadata and falls back to the original metadata on any NonFatal error, and
setSessionConf rebinds the value back to the session conf on restore. That
matches the intended behavior.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5963889917","thread_id":"conversation:5963889917","verdict_sha256":"086acadc2f07e9fc032c379c9c79f6515423d82abb315be352fe5fa6ddd49004"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
