DaemonforY opened a new pull request, #59228:
URL: https://github.com/apache/spark/pull/59228

   ### What changes were proposed in this pull request?
   
   This PR fixes a unit typo in the class-level comment of 
`PackedRecordPointer`: the maximum addressable page size is `2^27 bytes = 128 
megabytes`, not `2^27 bits`.
   
   ### Why are the changes needed?
   
   The 27-bit field is a byte offset within a page, so the maximum addressable 
page size is 2^27 **bytes** (128 MiB). This is consistent with:
   
   - the same comment, which says the offsets "are not 8-byte-word-aligned", 
and later that "Assuming word-alignment would allow for a 1 gigabyte maximum 
page size" (2^27 * 8 bytes = 1 GiB);
   - the constant right below it: `static final int MAXIMUM_PAGE_SIZE_BYTES = 1 
<< 27;  // 128 megabytes`.
   
   `2^27 bits` would only be 16 MiB, so the current wording is misleading.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. Comment-only change.
   
   ### How was this patch tested?
   
   Comment-only change; no tests are needed. The modified line is 99 
characters, within the 100-character limit enforced by `dev/checkstyle.xml`.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5.5
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to