HyukjinKwon commented on code in PR #59170:
URL: https://github.com/apache/spark/pull/59170#discussion_r4176164100
##########
python/pyspark/errors/tests/test_errors.py:
##########
@@ -49,6 +52,63 @@ def detect_duplication(pairs):
json.loads(ERROR_CLASSES_JSON, object_pairs_hook=detect_duplication)
+ def test_error_classes_used_in_source_are_valid(self):
Review Comment:
Thanks for making this more robust. The AST-based scan over all non-test
PySpark sources, validating each literal `errorClass` raise against the
template's exact parameter set via `get_error_message`, is a solid repo-wide
guard -- effectively the PySpark counterpart of the JVM `SparkThrowableSuite`.
This addresses my earlier comment on the approach.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"inline:4151943770","thread_id":"inline:4151943770","verdict_sha256":"28d5c56a048c4dd2535cbe09d2dce51fae4280c680c81bf3e3683e94379e4383"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
