viirya commented on PR #38:
URL:
https://github.com/apache/spark-connect-gateway/pull/38#issuecomment-5977440538
Closing: as filed this would delete two merged PRs' worth of work.
The intended change is six lines in `Cargo.lock` — `uuid` 1.24.0 to 1.26.1,
with
no manifest change since the requirement is already `uuid = "1"`. But the
branch
was cut before #40 and #42 landed, so the diff also reverts both of them:
```
dev/sync-protos.sh | 149 ------------------
proto/PROVENANCE.md | 114 ------------------
proto/spark/connect/pipelines.proto | 42 ---------
proto/spark/connect/relations.proto | 31 --------
README.md | 15 +---
Cargo.lock | 6 +-
```
That removes the proto provenance record and sync script (SPARK-59856) and
undoes
the sync to upstream `v4.2.0` (SPARK-59908), taking `proto/spark/connect/`
back to
being 2 files behind upstream with nothing recording where it came from.
It would also pass CI: deleting a documentation file and a shell script
breaks no
build, and reverting the two protos just returns the generated bindings to an
earlier valid state. So a green check here would not mean the change is safe.
`uuid` on its own is fine and will come back cleanly once dependabot
rebases, or
can ride along with another lockfile update. Not worth the risk of merging
this
diff for six lines of lockfile.
Thanks, dependabot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
