HyukjinKwon commented on PR #59143:
URL: https://github.com/apache/spark/pull/59143#issuecomment-5978075467
Thanks for extending the balanced-tree construction to the subquery,
decorrelation, cost-based join reorder, CTE-definition, and INTERSECT/EXCEPT
sites, and for adding the rule-level FilterPushdownSuite depth assertion. The
description now naming the sites left linear (bounded-operand folds and plan
canonicalization) addresses my earlier question about the remaining linear
sites. Since leaf order is preserved, short-circuiting and NULL semantics are
unchanged. This resolves my earlier comments.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5912887804","thread_id":"conversation:5912887804","verdict_sha256":"00c82329ca7a864c988dfabc966ab5df8cf7a943ac28e29b0c9fb14ce83ac1a3"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
