viirya commented on PR #59242: URL: https://github.com/apache/spark/pull/59242#issuecomment-6005820361
Thanks for the fix! One small wording suggestion for the **PR description’s “How was this patch tested?” section**: could we replace “training proceeds with the server disabled” with “execution reaches task-function creation with log streaming disabled”? The test intentionally stops there, which is sufficient for this logging fix. No change to the test itself is needed. Otherwise, LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
