uros-b commented on code in PR #58759:
URL: https://github.com/apache/spark/pull/58759#discussion_r4204546827
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8146,6 +8146,12 @@
},
"sqlState" : "42601"
},
+ "TABLES_OR_VIEWS_NOT_IN_SAME_DATABASE" : {
+ "message" : [
+ "Cannot retrieve tables or views that do not belong to the same
database. Requested: <qualifiedTableNames>."
+ ],
+ "sqlState" : "0A000"
Review Comment:
Is 0A000 right here?
0A000 is "feature not supported". This is a same-database restriction on
SessionCatalog.getTablesByName, not an unimplemented feature.
CANNOT_RENAME_ACROSS_SCHEMA already uses 0AKD0 ("Cross catalog or schema
operation not supported"), which is a closer match.
RENAME_TABLE_SOURCE_DESTINATION_DATABASE_MISMATCH uses 3F000. I'd prefer 0AKD0
here unless there is a reason to stay on 0A000.
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8146,6 +8146,12 @@
},
"sqlState" : "42601"
},
+ "TABLES_OR_VIEWS_NOT_IN_SAME_DATABASE" : {
+ "message" : [
+ "Cannot retrieve tables or views that do not belong to the same
database. Requested: <qualifiedTableNames>."
+ ],
+ "sqlState" : "0A000"
Review Comment:
let's cc @srielau here ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
