ykisana commented on PR #918: URL: https://github.com/apache/spark-kubernetes-operator/pull/918#issuecomment-6033135217
**Addressed in this PR** - `docs/configuration.md` and `docs/migration_guide.md`: dropped "ends when the response headers arrive" / "until their headers arrive" and now say it does not include the time to read the response body. The `401` sentence only describes the sum. - `docs/configuration.md`: a rejected WebSocket upgrade is now described as counted several times in `kubernetes.client.http.response` and the response code meters. - `after(...)` Javadoc: the re-send now refers to another interceptor's `afterFailure(...)` returning `true`, e.g. `TokenRefreshInterceptor` on a `401`, instead of linking to this class's `afterFailure(...)`. - `afterConnectionFailure(...)` Javadoc: reused the docs wording, "only while the request has a retry left, even if it does not retry it, e.g. on a request timeout." - `testResponseLatencyOfWebSocketUpgrade`: added `pollDelay(Duration.ZERO)`. - Moved `meterCount` to `TestUtils`, shared by `KubernetesMetricsInterceptorTest` and `KubernetesClientFactoryTest`. - PR description: added `testResponseLatencyOfTwoInterceptors`, the `owner` lookup, and the docs, Javadoc and helper changes. Also described the `401` re-send as the sum of the two values. **To be addressed separately (new issues/PRs)** - Client metrics table in `docs/configuration.md`: fix the names of `kubernetes.client.failed` and `kubernetes.client.1xx`-`5xx`, and the description of `failed`, which is marked for every non-2xx response that reaches the interceptor. - `IndexOutOfBoundsException` for a status code outside 100-599 in the response code group meters: add a bounds check. - With `spark.kubernetes.operator.metrics.sanitizePrometheusMetricsNameEnabled=false`, the `.nanos` name is kept while the values are in seconds. - File an upstream fabric8 issue for the re-send path (`after(...)` called again without `before(...)`/`consumer(...)`), and the WebSocket upgrade paths (no `after(...)` for a re-sent upgrade, 1+N calls for a rejected one). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
