peter-toth commented on PR #59199: URL: https://github.com/apache/spark/pull/59199#issuecomment-6043137074
One more thing I noticed while reviewing this, for after it merges. The `Alias` comes from `V2ExpressionUtils.toCatalystOpt`, which resolves nested references with `resolveRef[NamedExpression]`. So it also reaches: - a scan's reported partitioning, e.g. `bucket(4, s.x)`, where it blocks the scan merge and a storage-partitioned join on a nested key; - the write path's required ordering and clustering, where it keeps a redundant `Sort`. It might be better to strip the alias there, in one place. I filed [SPARK-60041](https://issues.apache.org/jira/browse/SPARK-60041) for it. That would make the strip in this PR unnecessary, but there is no need to hold this PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
