peter-toth commented on code in PR #951:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/951#discussion_r4210175984
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/kueue/KueuePodSetFlavor.java:
##########
@@ -25,27 +25,68 @@
import java.util.Map;
import java.util.Objects;
+import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
import io.fabric8.kubernetes.api.model.PodSpec;
+import io.fabric8.kubernetes.api.model.PodTemplateSpec;
import io.fabric8.kubernetes.api.model.Toleration;
/**
- * The node selector and tolerations of the ResourceFlavors which Kueue
assigned to a pod set.
+ * The node selector, tolerations, labels and annotations which Kueue assigned
to a pod set: the
+ * ones of its ResourceFlavors and of the podSetUpdates of the admission
checks of its Workload.
* Like Kueue built-in integrations, they are applied to the pods of the pod
set.
*
- * @param nodeSelector The merged `nodeLabels` of the ResourceFlavors.
- * @param tolerations The merged `tolerations` of the ResourceFlavors.
+ * @param nodeSelector The merged `nodeLabels` of the ResourceFlavors and
`nodeSelector` of the
+ * podSetUpdates.
+ * @param tolerations The merged `tolerations` of the ResourceFlavors and the
podSetUpdates.
+ * @param labels The merged `labels` of the podSetUpdates.
+ * @param annotations The merged `annotations` of the podSetUpdates.
*/
-public record KueuePodSetFlavor(Map<String, String> nodeSelector,
List<Toleration> tolerations) {
+public record KueuePodSetFlavor(
Review Comment:
**Finding 1.** The record now also holds the `labels`, `annotations`,
`nodeSelector` and `tolerations` of the admission checks, so `Flavor` no longer
describes what's in it. Kueue keeps the same merged shape in
`podset.PodSetInfo`. Renaming it to `KueuePodSetInfo` would say what it holds.
The Kueue integration isn't released yet, so a rename is cheap now. A follow-up
PR is fine too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
