LukaZdravic opened a new pull request, #59278:
URL: https://github.com/apache/spark/pull/59278
### What changes were proposed in this pull request?
Move the inline comment in `AsOfJoin.buildMatchExpressions` into a Scaladoc
and state it as the method's rule: the operands are compared as whole values,
so a NULL struct never matches, while a struct whose fields are all NULL can.
The Scaladoc also names the two returned expressions, `asOfCondition` and
`orderExpression`.
### Why are the changes needed?
Follow-up to SPARK-59858 (#59134). The old comment ("Compare the operands as
they are") only made sense next to the struct-rebuilding code that SPARK-59858
removed. The NULL STRUCT rule is the part a reader needs, so the Scaladoc keeps
that.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Comment-only change.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
