viirya commented on code in PR #954:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/954#discussion_r4212371136
##########
spark-operator/src/test/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppSuspendStepTest.java:
##########
@@ -734,6 +740,26 @@ void suspendingEvictedAppIsRecorded() {
Assertions.assertNull(getWorkload());
}
+ @Test
+ void evictionIsToldByTheSuspendReasonRatherThanByTheMessage() {
Review Comment:
Non-blocking: could we extend the existing Kueue e2e coverage to verify this
across an operator restart? After an eviction reaches `Suspended`, assert that
the API server retains `suspendReason: KueueEviction`, restart the operator,
and verify that a deactivated Workload remains held or an unexpired requeue
backoff is still honored.
The JSON round-trip and reconciliation tests cover the individual pieces
well. This would additionally verify the CRD persistence boundary and recovery
without the in-memory status cache, which matter now that this field determines
whether `keepKueueWorkload()` runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
