dongjoon-hyun commented on PR #59117: URL: https://github.com/apache/spark/pull/59117#issuecomment-6047766792
@viirya, FYI, the CI run on the latest commit, 517133c, still fails because of item 1 of my earlier review. [`Build modules: sql - other tests`](https://github.com/viirya/spark-1/actions/runs/37674561361/job/112982909702) has one test failure, and all the other jobs pass: ``` ParquetVectorizedSuite: SPARK-59831: BYTE_STREAM_SPLIT page of a required column with a wrong value count org.scalatest.exceptions.TestFailedException: Expected exception org.apache.parquet.io.ParquetDecodingException to be thrown, but java.lang.RuntimeException was thrown ``` The widened `catch (IOException | ParquetDecodingException e)` in `VectorizedColumnReader.readPageV1`/`readPageV2` also wraps the `ParquetDecodingException` that `VectorizedByteStreamSplitValuesReader.initFromPage` throws (SPARK-59831), and `readPage()` then rethrows it as a `RuntimeException`. The same test is on branch-4.x and branch-4.3, so the backports would fail the same way. Could you keep the exception type in that catch (item 2) or update that test in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
