zifeif2 commented on code in PR #59219:
URL: https://github.com/apache/spark/pull/59219#discussion_r4213557072
##########
connector/kafka-0-10-sql/src/main/resources/error/kafka-error-conditions.json:
##########
@@ -117,6 +117,24 @@
},
"sqlState" : "22000"
},
+ "KAFKA_INVALID_BATCH_OFFSET" : {
+ "message" : [
+ "<offsetName>"
Review Comment:
The rest of the error message is in the subclass
Test also assert it
```
testInvalidBatchOffset(
"subscribe" -> "t",
"endingOffsets" -> endingOffsets)(
condition = "KAFKA_INVALID_BATCH_OFFSET.TOPIC_OR_PARTITION",
parameters = Map(
"offsetName" -> "endingOffsets",
"offsetValue" -> "earliest",
"topicOrPartition" -> "t-0"),
expectedMessage = "endingOffsets for t-0 can't be earliest for batch
queries on Kafka")
```
##########
connector/kafka-0-10-sql/src/main/resources/error/kafka-error-conditions.json:
##########
@@ -117,6 +117,24 @@
},
"sqlState" : "22000"
},
+ "KAFKA_INVALID_BATCH_OFFSET" : {
+ "message" : [
+ "<offsetName>"
+ ],
+ "subClass" : {
+ "GLOBAL" : {
Review Comment:
It's contrary to per partition failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
