srielau commented on PR #58549: URL: https://github.com/apache/spark/pull/58549#issuecomment-6051106177
Addressed the Oct 7 P2 in 61532951d23. **Do not mask CHAR/VARCHAR validation as a transpilation failure:** Classic `UserDefinedFunction.__init__` now re-raises `PySparkNotImplementedError` from the transpile try, so DDL `char(n)` / `varchar(n)` stays `CHAR_VARCHAR_NOT_SUPPORTED_IN_PYTHON` instead of a transpile UserWarning. Covered by `UDFTranspileUnitTests.test_udf_transpile_does_not_mask_char_varchar_ddl` (transpile + ANSI, ordinary warnings, and warnings-as-errors). Real transpile fallback is unchanged (`test_udf_transpile_chained_comparison_falls_back`). Connect has no transpile try around `returnType`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
