anew commented on code in PR #59309:
URL: https://github.com/apache/spark/pull/59309#discussion_r4224533906
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/pipelines/PythonPipelineSuite.scala:
##########
@@ -972,15 +972,13 @@ class PythonPipelineSuite
}
/**
- * Builds the graph and runs it through resolution and validation, returning
the resolved
- * [[AutoCdcMergeFlow]]. Unlike [[buildAutoCdcFlow]], this exercises the
graph analysis that
- * rejects invalid change args (e.g. an ignore-null column that is also a
key), so a test that
- * asserts on the resolved flow is guaranteed to describe a usable
configuration.
+ * Builds and resolves the graph, returning the resolved
[[AutoCdcMergeFlow]]. Unlike
+ * [[buildAutoCdcFlow]], this exercises the flow analysis that rejects
invalid change args (e.g.
+ * an ignore-null column that is also a key), so a test that asserts on the
resolved flow is
+ * guaranteed to describe a configuration the flow accepts.
*/
private def resolveAutoCdcMergeFlow(pipelineSource: String):
AutoCdcMergeFlow = {
- val graph = buildGraph(pipelineSource)
- .resolve(sessionCaseSensitive)
- .validate(sessionCaseSensitive)
Review Comment:
We can just bring this back when ignore-null is fully merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
