AnishMahto commented on code in PR #58973: URL: https://github.com/apache/spark/pull/58973#discussion_r4225384679
########## sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/autocdc/Scd1VersionMap.scala: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.pipelines.autocdc + +import org.apache.spark.sql.types.{DataType, MapType, StringType} + +/** + * Per-leaf authorship sequences for SCD1 reconciliation. + * + * An SCD1 target row can combine values authored by different CDC events. The version map records + * which event currently authors each non-key user-data leaf. + */ +private[pipelines] object Scd1VersionMap { + + /** + * Schema of the version map: `Map(String, sequencingType)`. + * + * Each key is the field path of a user-data leaf. Each value is the leaf's authorship sequence: + * the sequencing value of the event that authored the leaf, or null if no event has authored it. + * + * @param sequencingType The resolved data type of the flow's sequencing expression. + */ Review Comment: The exact contract for the contents of the version map are defined in the next PR in this stack, where we simultaneously introduce the logic to construct version maps as per the defined contract. This PR only cares about the data type of the version map, and that it is added to the schema of the CDC metadata column. At this point the actual contents of the version map are irrelevant to any implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
