viirya commented on PR #45:
URL:
https://github.com/apache/spark-connect-gateway/pull/45#issuecomment-6087487325
Superseded by #43, which was merged as 131c830 and makes exactly the same
dependency change: `opentelemetry*` 0.32 -> 0.33 and `tracing-opentelemetry`
0.33 -> 0.34. The two trees were byte-identical, and both resolved to a
single
`opentelemetry` 0.33.0 in `Cargo.lock`.
Closing rather than leaving it open because this branch is still based on
f154d51, which predates #44 (the Rust toolchain pin). Its diff against
current
`main` is no longer the dependency bump -- that part is already in -- but a
revert of #44:
```
crates/auth/src/lib.rs | 5 -----
crates/routing/src/lib.rs | 5 -----
rust-toolchain.toml | 12 +-----------
```
That would put `channel = "stable"` back and drop both
`#[allow(clippy::double_must_use)]` attributes, turning `main` red again for
the same reason #44 fixed. GitHub reports this PR as `mergeable: true`, so
there is nothing to signal the problem at merge time.
No action needed on the dependabot side -- the upgrade itself has landed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
