SavicStefan commented on code in PR #59252:
URL: https://github.com/apache/spark/pull/59252#discussion_r4229212902
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/thetasketchesAggregates.scala:
##########
@@ -44,8 +44,22 @@ case class UnionAggregationBuffer(union: Union) extends
ThetaSketchState {
override def eval(): Array[Byte] = union.getResult.toByteArrayCompressed
}
case class IntersectionAggregationBuffer(intersection: Intersection) extends
ThetaSketchState {
- override def serialize(): Array[Byte] =
intersection.getResult.toByteArrayCompressed
- override def eval(): Array[Byte] =
intersection.getResult.toByteArrayCompressed
+ override def serialize(): Array[Byte] = {
Review Comment:
Nice improvement, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
