LuciferYang commented on PR #58881: URL: https://github.com/apache/spark/pull/58881#issuecomment-6098653590
Thanks @MaxGekk, the repro settles it. Done in c841872: - Merged master and replaced the old test with your UNPIVOT query, run with `spark.sql.codegen.wholeStage.splitExpressions` on and off. It fails without the `ExpandExec` change. - Removed `CompactedSlot`, `isCompactedSlot` and the slot clause in `collectInputs`, along with the mentions of the rule in the conf doc and in `WholeStageCodegenExec`. - Removed the SPARK-33301 test you pointed at. The other slot test still passes and covers a split method reading the Expand's output, so I kept it. The two `CollectInputsSuite` slot cases are replaced by one that pins how `collectInputs` treats a field handed out as a global and as a variable. The description is updated and the PR is out of draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
