luc-pimentel commented on code in PR #59326:
URL: https://github.com/apache/spark/pull/59326#discussion_r4238312966
##########
python/pyspark/sql/conversion.py:
##########
@@ -543,7 +544,9 @@ def _convert_column_legacy(
# trigger the cast fallback when arrow_cast is enabled.
try:
try:
- return pa.Array.from_pandas(series, mask=mask,
type=arrow_type, safe=safecheck)
+ return _create_array_from_pandas(
Review Comment:
Added `test_from_pandas_arrow_dtype_requested_type_legacy_error_handling`
with `use_legacy_error_handling=True, arrow_cast=True`. With the legacy call
site reverted to the raw constructor it fails on PyArrow 18 with int32 instead
of int64; on the current code the module (57 tests) passes on PyArrow 18.0.0,
19.0.0 and 25.0.1.
---
Generated-by: Claude Code 2.1.296 (claude-fable-5-1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
