srielau commented on PR #59315: URL: https://github.com/apache/spark/pull/59315#issuecomment-6100566924
Closing this PR. \`from_csv\` CHAR/VARCHAR standard support is already complete on master: the STRING converter applies \`applyTextParseSemantics\` (pad CHAR, \`EXCEED_LIMIT_LENGTH\` on VARCHAR overflow). CSV does not parse \`MAP\`/\`ARRAY\`/\`STRUCT\`, so the JSON/XML map-key work in #59325 and #59316 does not apply here and does not remove any helper this path depends on. The remaining CHAR-column filter skip does not fix a Spark-SQL-generated mismatch. Spark's own equality is either already padded (\`CAST(... AS CHAR(n))\`) or is STRING comparison after the scan (\`c = 'ab'\`). The exclusion only changes a hand-built \`EqualTo\` in the parser unit test, at the cost of skipping parser-level filters on every CHAR column. That is not worth landing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
