gaogaotiantian commented on PR #59374: URL: https://github.com/apache/spark/pull/59374#issuecomment-6107033873
We should only add tests for extra coverage. We do not create a large test class to cover a whole file. https://app.codecov.io/gh/apache/spark/blob/master/python%2Fpyspark%2Fsql%2Futils.py shows about 13 line missing and we only need to improve those. We should not test util directly unless we have to. We should test the actual pyspark public API and cover the utils. `to_str` is already fully covered but you still wrote tests for it - it's unnecessary. We need precise tests targeting a specific goal, not a huge test class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
