bearomorphism opened a new pull request, #59393:
URL: https://github.com/apache/spark/pull/59393

   ### What changes were proposed in this pull request?
   
   Annotate callback inputs in `python/pyspark/pandas/datetimes.py` as 
`pd.Series` or `pd.DataFrame`, removing all 20 `no-untyped-def` suppressions. 
Keep the five `valid-type` suppressions for runtime-generated return-schema 
annotations.
   
   ### Why are the changes needed?
   
   The callbacks receive pandas objects, so their input types can be declared 
directly instead of suppressing the typed-definition check. Existing return 
annotations continue to define the Spark output schemas.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. Only internal input annotations and suppression comments change; 
callback logic and output schemas are unchanged.
   
   ### How was this patch tested?
   
   - Mypy passed on all 596 files in `python/pyspark/pandas`, independently of 
the accessor typing change.
   - `pyspark.pandas.tests.series.test_datetime`: 42 tests total, with 35 
passing, five pre-existing skips, and two expected failures.
   - Separate runtime checks for `month_name()` and `day_name()` with the 
default locale matched pandas output; their existing locale-specific tests are 
skipped.
   - Ruff lint/format checks and `git diff --check` passed.
   
   No new tests were added; the existing datetime suite and local runtime 
checks cover these callbacks.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: pi 1.1.0 with OpenAI gpt-6-astra
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to