HyukjinKwon commented on PR #59214:
URL: https://github.com/apache/spark/pull/59214#issuecomment-6125568620
Thanks for the updates. I rechecked the latest commit and all three earlier
nits look addressed: the float32 midpoint tie is now resolved against the exact
decimal, the double search starts from repr()'s digit count with the
power-of-two retry gated on frexp, and the test now pins 0.1 + 0.2 and the
1800-01-01 Los Angeles LMT offset. The review posted alongside this reply has
the details.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6122673107","thread_id":"conversation:6122673107","verdict_sha256":"ef286150477e4f71e814af23255a2ae5ff3430e17902ccea5c6410200e21ecc9"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
