ssirowa14 commented on code in PR #925: URL: https://github.com/apache/spark-kubernetes-operator/pull/925#discussion_r4252524918
########## docs/migration_guide.md: ########## @@ -159,6 +159,27 @@ affect building the project, CI, tests or examples. `driverStartTimeoutMillis` was disabled. Since `DriverStartTimedOut` is an infrastructure failure while the others are not, `restartPolicy: OnInfrastructureFailure` no longer restarts such an application. Use `OnFailure` to restart it. +- Since 1.1.0, a label set on a secondary resource of the driver takes precedence over a label of + the same key on the driver pod, instead of being overwritten by it. This affects the user-defined + labels in `spec.driverServiceIngressList` (`serviceMetadata`, `ingressMetadata`), + `spec.driverHttpRouteList` (`serviceMetadata`, `httpRouteMetadata`), `spec.driverGrpcRouteList` + (`serviceMetadata`, `grpcRouteMetadata`) and `spec.configMapSpecs`, as well as the other + Kubernetes resources of the driver, e.g. its service with `spark.kubernetes.driver.service.label.*` + and its on-demand PVCs with `spark.kubernetes.driver.volumes.persistentVolumeClaim.<name>.label.*`. + 1.0 overwrote these labels with the driver-pod labels of the same key, including the ones injected + into the driver pod by admission webhooks. The operator- and Spark-managed identity labels, i.e. any `spark.operator/` Review Comment: I've refactored migration guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
