Yicong-Huang opened a new pull request, #59417:
URL: https://github.com/apache/spark/pull/59417

   ### What changes were proposed in this pull request?
   
   Move the module-level test helpers in `test_arrow_eval_type_handlers.py` and 
`test_pandas_eval_type_handlers.py` onto the test classes that use them.
   
   - Helpers shared by several classes go on a per-file base `TestCase` 
(`ArrowEvalTypeHandlerTestCase`, `PandasEvalTypeHandlerTestCase`) as 
static/class methods; the handler test classes extend it.
   - Helpers used by one class become members of that class (e.g. 
`_one_cogroup`, the pandas scalar/scalar-iter/map `_handler` builders, the 
arg-offset constants).
   
   Test-only; no assertions change.
   
   ### Why are the changes needed?
   
   Follow-up to the review on #59312: keeping helpers on the classes that use 
them makes it easier to track where each one is used.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests: `pyspark.eval_handlers.tests.test_arrow_eval_type_handlers` 
and `pyspark.eval_handlers.tests.test_pandas_eval_type_handlers` (65 tests, 
same count as before) pass.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5.5
   
   This pull request and its description were written by Isaac.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to